[codex] Upgrade protobuf to 4.34.0

[xiangfu0]

Summary

• Upgrade the shared protobuf.version to 4.34.0.
• Upgrade the shared confluent.version to 8.2.0, which publishes protobuf 4.x artifacts.
• Add an explicit com.google.code.findbugs:jsr305 dependency to pinot-confluent-protobuf so the module still gets javax.annotation types after the shared protobuf upgrade.
• Fix the Confluent Avro schema-registry integration test for the Confluent 8.2 serializer API change.

Why

Pinot should move its shared protobuf dependency to 4.x without leaving the Confluent input plugins on an older serializer stack. Confluent 8.2.0 now aligns with protobuf 4.x, so the repo can move both versions forward together instead of carrying a plugin-local protobuf 3.x carve-out.

The version bump also surfaced one direct source-level compatibility issue in tests: Confluent 8.2 removed AbstractKafkaAvroSerDeConfig, so Pinots Avro schema-registry integration test needs to use AbstractKafkaSchemaSerDeConfig instead.

User / Developer Impact

• Pinot now builds against protobuf 4.34.0 and Confluent 8.2.0.
• pinot-confluent-protobuf stays on the shared protobuf 4.x line instead of maintaining a separate protobuf 3.x island.
• The Confluent Avro integration test matches the current Confluent serializer API.
• pinot-confluent-protobuf no longer relies on transitive resolution for javax.annotation types.

Root Cause

1. pinot-confluent-protobuf referenced javax.annotation.Nullable and javax.annotation.ParametersAreNonnullByDefault without declaring JSR-305 directly.
2. Confluent 8.2 removed io.confluent.kafka.serializers.AbstractKafkaAvroSerDeConfig, but Pinot integration test code still imported it.

How To Reproduce

1. Start from current master.
2. Upgrade the shared protobuf.version to a protobuf 4.x release and the shared confluent.version to 8.2.0.
3. Run ./mvnw -pl pinot-plugins/pinot-input-format/pinot-confluent-protobuf -am -DskipITs -Dskip.integration.tests=true -DskipTests compile.
4. Observe missing javax.annotation compilation failures unless jsr305 is declared explicitly.
5. Run a build that compiles pinot-integration-tests and observe the stale AbstractKafkaAvroSerDeConfig import fail against Confluent 8.2.

Validation

• ./mvnw -pl pinot-integration-tests spotless:apply
• ./mvnw -pl pinot-integration-tests checkstyle:check
• ./mvnw -pl pinot-integration-tests license:format
• ./mvnw -pl pinot-integration-tests license:check
• ./mvnw -pl pinot-common,pinot-server,pinot-query-planner,pinot-query-runtime -am -DskipITs -Dskip.integration.tests=true -DskipTests compile
• ./mvnw -pl pinot-plugins/pinot-input-format/pinot-confluent-protobuf -am -DskipITs -Dskip.integration.tests=true -DskipTests compile
• ./mvnw -pl pinot-plugins/pinot-input-format/pinot-confluent-avro,pinot-plugins/pinot-input-format/pinot-confluent-json,pinot-plugins/pinot-input-format/pinot-confluent-protobuf -am -DskipITs -Dskip.integration.tests=true -DskipTests compile

Known Test Limitation

• The Docker-backed Confluent protobuf schema-registry tests still cannot run in this environment because there is no Docker socket for Testcontainers.

[Copilot]

Pull request overview

Upgrades Apache Pinot’s shared Protocol Buffers dependency to the 4.x line and fixes a build break in the pinot-confluent-protobuf module by making its javax.annotation (JSR-305) annotations dependency explicit.

Changes:

• Bump root protobuf.version from 3.25.9 to 4.34.0 (affecting protobuf BOM / protoc usage across the build).
• Add an explicit com.google.code.findbugs:jsr305 dependency to pinot-confluent-protobuf to restore access to javax.annotation.Nullable / ParametersAreNonnullByDefault under protobuf 4.x.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pom.xml	Updates the shared protobuf version property used by protobuf BOM and protoc artifact resolution.
pinot-plugins/pinot-input-format/pinot-confluent-protobuf/pom.xml	Declares jsr305 directly so the module compiles without relying on removed transitive annotations.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.27%. Comparing base (c23b8fd) to head (9c0b140).

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #17995      +/-   ##
============================================
- Coverage     63.37%   63.27%   -0.10%     
  Complexity     1543     1543              
============================================
  Files          3200     3200              
  Lines        194169   194169              
  Branches      29915    29915              
============================================
- Hits         123051   122867     -184     
- Misses        61466    61650     +184     
  Partials       9652     9652              

Flag	Coverage Δ
custom-integration1	100.00% <ø> (ø)
integration	100.00% <ø> (ø)
integration1	100.00% <ø> (ø)
integration2	0.00% <ø> (ø)
java-11	63.25% <ø> (-0.02%)	⬇️
java-21	63.25% <ø> (-0.09%)	⬇️
temurin	63.27% <ø> (-0.10%)	⬇️
unittests	63.27% <ø> (-0.10%)	⬇️
unittests1	55.52% <ø> (-0.03%)	⬇️
unittests2	34.19% <ø> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[Jackie-Jiang]

Can you try also bumping google cloud version? I think it should also be bumped after upgrading protobuf

[Jackie-Jiang]

Is this necessary?

[xiangfu0]

Yes, it is necessary. The module directly uses @Nullable from javax.annotation in KafkaConfluentSchemaRegistryProtoBufMessageDecoder.java (4 usages). Without it, compilation fails with 5 errors. After protobuf 4.x, protobuf-java no longer transitively pulls in jsr305 at compile scope.

That said, I've added <scope>provided</scope> since it's only needed at compile time for annotations and shouldn't be bundled into the shaded plugin JAR.

[Jackie-Jiang]

Should we just include it in pinot-spi? This is a very basic dependency which should be included in all modules

[xiangfu0]

jsr305 is already transitively available to all core modules via Guava in pinot-spi (guava -> jsr305:3.0.2:compile). The reason pinot-confluent-protobuf needs it explicitly is that plugin modules declare pinot-spi with provided scope, which makes its transitive dependencies (including jsr305 via Guava) unavailable at compile time.

So adding jsr305 to pinot-spi explicitly wouldn't change anything for plugins — they'd still need their own declaration. The current approach (explicit jsr305 with provided scope in this plugin module) is the minimal correct fix.

[xiangfu0]

Bumped google.cloud.libraries.version from 26.74.0 to 26.79.0 (latest stable). It uses protobuf 4.33.2 internally which is compatible with our 4.34.0 since Pinot's protobuf-bom takes precedence. GCS plugin compiles cleanly.