[cleanup]Remove SelectionOperatorService heapsort fallback for pre-1.3.0#18000
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Mar 27, 2026
Merged
[cleanup]Remove SelectionOperatorService heapsort fallback for pre-1.3.0#18000xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0 merged 1 commit intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18000 +/- ##
============================================
- Coverage 63.36% 63.30% -0.06%
Complexity 1543 1543
============================================
Files 3200 3200
Lines 194114 194074 -40
Branches 29893 29883 -10
============================================
- Hits 122993 122866 -127
- Misses 61461 61570 +109
+ Partials 9660 9638 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The method no longer handles unsorted dataTables after removing the heapsort fallback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
xiangfu0
force-pushed
the
cleanup-heapsort-fallback
branch
from
f4b7e58 to
3cf0d4b
Compare
xiangfu0
changed the title
xiangfu0
added
cleanup
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes legacy broker-side sorting fallback logic from SelectionOperatorService, relying on the contract that supported server versions (>= 1.3.0) return sorted DataTables for ORDER BY selection queries.
Changes:
- Removed the broker-side “check SORTED metadata then heapsort fallback” compatibility path for pre-1.3.0 servers.
- Deleted the now-dead
heapSortDataTable()implementation and its unused import(s). - Updated method documentation to reflect that inputs are expected to be sorted.
Jackie-Jiang
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
heapSortDataTable()method from SelectionOperatorServiceThe TODO comments explicitly stated: "remove after 1.2.0 no longer supported."
Test plan
heapSortDataTableremain in the codebase./mvnw spotless:apply -pl pinot-corepasses./mvnw checkstyle:check -pl pinot-corepasses./mvnw license:check -pl pinot-corepasses🤖 Generated with Claude Code