Fix dependency verifier test MavenProject setup#18016
Closed
xiangfu0 wants to merge 1 commit intoapache:masterfrom
Closed
Fix dependency verifier test MavenProject setup#18016xiangfu0 wants to merge 1 commit intoapache:masterfrom
xiangfu0 wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18016 +/- ##
============================================
+ Coverage 55.55% 63.28% +7.73%
- Complexity 752 1543 +791
============================================
Files 2505 3200 +695
Lines 143118 194169 +51051
Branches 22967 29915 +6948
============================================
+ Hits 79504 122889 +43385
- Misses 56877 61625 +4748
- Partials 6737 9655 +2918
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4ae018e to
2785a1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MavenProjectmock inPinotCustomDependencyVersionRuleTestwith realMavenProjectfixturesMavenSessionrooted at the top-level project so the test no longer depends on Mockito inline bytecode instrumentation of Maven internalsMutableColumnStatisticsTeston current master by stubbingDictionary.getValueSize()in the mock setupPinot Unit Test Set 2failure was introduced by PR Add getValueSize() to Dictionary and ValueReader to avoid buffer allocation #18012 (fe3e5deebd), which switchedMutableColumnStatisticsto useDictionary.getValueSize()Testing