Skip to content

Fix dependency verifier test MavenProject setup#18016

Closed
xiangfu0 wants to merge 1 commit intoapache:masterfrom
xiangfu0:codex/fix-pinot-dependency-verifier-mavenproject-test
Closed

Fix dependency verifier test MavenProject setup#18016
xiangfu0 wants to merge 1 commit intoapache:masterfrom
xiangfu0:codex/fix-pinot-dependency-verifier-mavenproject-test

Conversation

@xiangfu0
Copy link
Copy Markdown
Contributor

@xiangfu0 xiangfu0 commented Mar 28, 2026

Summary

  • replace the Mockito MavenProject mock in PinotCustomDependencyVersionRuleTest with real MavenProject fixtures
  • use a lightweight real MavenSession rooted at the top-level project so the test no longer depends on Mockito inline bytecode instrumentation of Maven internals
  • keep the existing rule assertions intact while modeling real root/submodule pom paths
  • fix MutableColumnStatisticsTest on current master by stubbing Dictionary.getValueSize() in the mock setup
  • note that the current Pinot Unit Test Set 2 failure was introduced by PR Add getValueSize() to Dictionary and ValueReader to avoid buffer allocation #18012 (fe3e5deebd), which switched MutableColumnStatistics to use Dictionary.getValueSize()

Testing

  • ./mvnw spotless:apply -pl pinot-dependency-verifier
  • ./mvnw checkstyle:check -pl pinot-dependency-verifier
  • ./mvnw license:format -pl pinot-dependency-verifier
  • ./mvnw license:check -pl pinot-dependency-verifier
  • ./mvnw -pl pinot-dependency-verifier test
  • ./mvnw spotless:apply -pl pinot-segment-local
  • ./mvnw checkstyle:check -pl pinot-segment-local
  • ./mvnw license:format -pl pinot-segment-local
  • ./mvnw license:check -pl pinot-segment-local
  • JAVA_HOME=$(brew --prefix openjdk@21)/libexec/openjdk.jdk/Contents/Home PATH=$(brew --prefix openjdk@21)/bin:$PATH ./mvnw -pl pinot-segment-local -am -DskipITs -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -Dtest=MutableColumnStatisticsTest test
  • JAVA_HOME=$(brew --prefix openjdk@11)/libexec/openjdk.jdk/Contents/Home PATH=$(brew --prefix openjdk@11)/bin:$PATH ./mvnw -pl pinot-segment-local -Dtest=MutableColumnStatisticsTest test -DskipITs -DskipUTs=false

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.28%. Comparing base (6c99b6b) to head (2785a1e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18016      +/-   ##
============================================
+ Coverage     55.55%   63.28%   +7.73%     
- Complexity      752     1543     +791     
============================================
  Files          2505     3200     +695     
  Lines        143118   194169   +51051     
  Branches      22967    29915    +6948     
============================================
+ Hits          79504   122889   +43385     
- Misses        56877    61625    +4748     
- Partials       6737     9655    +2918     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 55.48% <ø> (-0.02%) ⬇️
java-21 63.26% <ø> (+7.74%) ⬆️
temurin 63.28% <ø> (+7.73%) ⬆️
unittests 63.28% <ø> (+7.73%) ⬆️
unittests1 55.53% <ø> (-0.02%) ⬇️
unittests2 34.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiangfu0 xiangfu0 force-pushed the codex/fix-pinot-dependency-verifier-mavenproject-test branch from 4ae018e to 2785a1e Compare March 29, 2026 01:47
@xiangfu0 xiangfu0 closed this Mar 29, 2026
@xiangfu0 xiangfu0 deleted the codex/fix-pinot-dependency-verifier-mavenproject-test branch March 29, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants