Skip to content

Introduce error propagation via OpChainConverter to streamline stage failure handling#18026

Merged
gortiz merged 1 commit intoapache:masterfrom
gortiz:opchain-converter-pipeline-breaker
Apr 1, 2026
Merged

Introduce error propagation via OpChainConverter to streamline stage failure handling#18026
gortiz merged 1 commit intoapache:masterfrom
gortiz:opchain-converter-pipeline-breaker

Conversation

@gortiz
Copy link
Copy Markdown
Contributor

@gortiz gortiz commented Mar 30, 2026

In #17974, we introduced an SPI to convert opchains, but we missed the ability to use that SPI when an error is detected on pipeline breakers. This PR fixes that issue

@gortiz gortiz requested a review from yashmayya March 30, 2026 15:56
@gortiz gortiz closed this Mar 30, 2026
@gortiz gortiz force-pushed the opchain-converter-pipeline-breaker branch from b31a144 to 7f95c28 Compare March 30, 2026 16:01
@gortiz gortiz reopened this Mar 30, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.32%. Comparing base (ecaf0f8) to head (7f95c28).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...che/pinot/query/runtime/plan/OpChainConverter.java 43.75% 7 Missing and 2 partials ⚠️
...va/org/apache/pinot/query/runtime/QueryRunner.java 80.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18026      +/-   ##
============================================
+ Coverage     63.30%   63.32%   +0.02%     
  Complexity     1543     1543              
============================================
  Files          3200     3200              
  Lines        194169   194167       -2     
  Branches      29915    29915              
============================================
+ Hits         122914   122955      +41     
+ Misses        61610    61567      -43     
  Partials       9645     9645              
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.29% <62.50%> (+0.02%) ⬆️
java-21 63.26% <62.50%> (+<0.01%) ⬆️
temurin 63.32% <62.50%> (+0.02%) ⬆️
unittests 63.32% <62.50%> (+0.02%) ⬆️
unittests1 55.56% <62.50%> (+0.01%) ⬆️
unittests2 34.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: LOW risk change (4 files, +107 net lines), bug fix for SPI error propagation, all 16 CI checks passed, comprehensive test coverage added.

@gortiz gortiz merged commit 736ac51 into apache:master Apr 1, 2026
31 of 32 checks passed
@gortiz gortiz deleted the opchain-converter-pipeline-breaker branch April 1, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants