Draft
Conversation
xiangfu0
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18046 +/- ##
=========================================
Coverage 63.34% 63.34%
+ Complexity 1543 1542 -1
=========================================
Files 3200 3200
Lines 194222 194220 -2
Branches 29934 29934
=========================================
+ Hits 123026 123034 +8
+ Misses 61526 61504 -22
- Partials 9670 9682 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiangfu0
force-pushed
the
codex/raise-java-baseline-21
branch
from
4c94562 to
0caf9db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pinot-spi,pinot-segment-spi,pinot-timeseries-spi,pinot-common,pinot-java-client,pinot-jdbc-client) on Java 11 bytecodeWhy
Issue #15343 proposes moving Pinot services to Java 21 while preserving lower-bytecode compatibility for library artifacts consumed from external JVMs. The service modules need the Java 21 baseline, but the SPI and client modules still need to publish lower-target artifacts so consumers do not inherit Java 21-only jars.
Impact
Validation
./mvnw -pl pinot-query-runtime,pinot-timeseries/pinot-timeseries-planner,pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql -am spotless:apply -DskipTests./mvnw -pl pinot-query-runtime,pinot-timeseries/pinot-timeseries-planner,pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql -am checkstyle:check license:format license:check -DskipTests./mvnw -pl pinot-query-runtime,pinot-timeseries/pinot-timeseries-planner,pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql -am package -DskipTests -DskipShade -T1C./mvnw -pl pinot-spi,pinot-segment-spi,pinot-common,pinot-timeseries/pinot-timeseries-spi,pinot-clients/pinot-java-client,pinot-clients/pinot-jdbc-client -am spotless:apply -DskipTests./mvnw -pl pinot-spi,pinot-segment-spi,pinot-common,pinot-timeseries/pinot-timeseries-spi,pinot-clients/pinot-java-client,pinot-clients/pinot-jdbc-client -am checkstyle:check license:format license:check -DskipTests./mvnw -pl pinot-spi,pinot-segment-spi,pinot-common,pinot-timeseries/pinot-timeseries-spi,pinot-clients/pinot-java-client,pinot-clients/pinot-jdbc-client -am package -DskipTests -DskipShade -T1C