Change default Scala version to 2.13#18100
Merged
xiangfu0 merged 2 commits intoapache:masterfrom Apr 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Switches Pinot’s default Scala toolchain from 2.12 to 2.13 while preserving a -Pscala-2.12 fallback, and updates Scala-suffixed dependencies and tests accordingly.
Changes:
- Set Scala 2.13 as the default (
scala.version/scala.compat.version) and keep ascala-2.12Maven profile for fallback builds. - Make Scala-suffixed dependency coordinates (e.g., chill) follow
${scala.compat.version}and refreshLICENSE-binaryto match the default Scala 2.13 artifacts. - Update Spark common Scala tests to avoid Scala 2.13 array equality pitfalls.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Defaults Scala to 2.13, adds 2.12 fallback profile, and parameterizes Scala-suffixed deps (e.g., chill). |
| pinot-plugins/pinot-input-format/pinot-confluent-json/pom.xml | Clarifies why scala-library test dep remains pinned to Scala 2.13 even under -Pscala-2.12. |
| pinot-connectors/pinot-spark-common/src/test/scala/org/apache/pinot/connector/spark/common/PinotDataSourceWriteOptionsTest.scala | Adjusts assertions to compare arrays via toSeq under Scala 2.13. |
| pinot-connectors/pinot-spark-common/pom.xml | Renames Scala build profile to avoid coupling it to a specific Scala version. |
| pinot-connectors/pinot-spark-3-connector/pom.xml | Renames Scala build profile similarly. |
| LICENSE-binary | Updates listed Scala-suffixed artifacts to the default Scala 2.13 variants. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18100 +/- ##
=========================================
Coverage 63.85% 63.85%
Complexity 1573 1573
=========================================
Files 3167 3167
Lines 192099 192092 -7
Branches 29604 29601 -3
=========================================
+ Hits 122657 122669 +12
+ Misses 59788 59768 -20
- Partials 9654 9655 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jackie-Jiang
approved these changes
Apr 4, 2026
xiangfu0
added a commit
to pinot-contrib/pinot-docs
that referenced
this pull request
Apr 5, 2026
Contributor
Author
|
📝 Documentation update PR: pinot-contrib/pinot-docs#696 This documentation PR updates the Pinot docs to reflect the new default Scala 2.13 version. It includes updates to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Pscala-2.12as the fallbackLICENSE-binaryValidation