Add IGNORE NULLS support for LEAD and LAG window functions#18202
Open
yashmayya wants to merge 1 commit intoapache:masterfrom
Open
Add IGNORE NULLS support for LEAD and LAG window functions#18202yashmayya wants to merge 1 commit intoapache:masterfrom
yashmayya wants to merge 1 commit intoapache:masterfrom
Conversation
e7fa9b1 to
50c6b87
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18202 +/- ##
============================================
+ Coverage 63.31% 63.34% +0.03%
Complexity 1627 1627
============================================
Files 3229 3238 +9
Lines 196707 197020 +313
Branches 30408 30471 +63
============================================
+ Hits 124538 124801 +263
- Misses 62192 62219 +27
- Partials 9977 10000 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PinotLeadWindowFunction/PinotLagWindowFunction(which blockedIGNORE NULLSat the Calcite level) with standardSqlStdOperatorTable.LEAD/SqlStdOperatorTable.LAGprocessRowsIgnoreNulls()toLeadValueWindowFunctionandLagValueWindowFunctionusing a boundedArrayDequefor O(N) time and O(offset) memoryoffsetnon-null valuesLEAD/LAG(col),LEAD/LAG(col, offset), andLEAD/LAG(col, offset, default)@Nullableannotation toWindowFunction.extractValueFromRow()LeadValueWindowFunction("LAG" → "LEAD")