Skip to content

Fix typos and improve comments in RefreshSegmentTaskExecutor #18228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
farhan131004 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

Fix typos and improve comments in RefreshSegmentTaskExecutor #18228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .../java/org/apache/pinot/plugin/minion/tasks/refreshsegment/RefreshSegmentTaskExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ protected SegmentConversionResult convert(PinotTaskConfig pinotTaskConfig, File
_eventObserver.notifyProgress(pinotTaskConfig, "Refreshing segment: " + indexDir);

// We set _taskStartTime before fetching the tableConfig. Task Generation relies on tableConfig/Schema updates
// happening after the last processed time. So we explicity use the timestamp before fetching tableConfig as the
// processedTime.
// happening after the last processed time. So we explicitly use the timestamp before fetching tableConfig as the processed time.
_taskStartTime = System.currentTimeMillis();
Map<String, String> configs = pinotTaskConfig.getConfigs();
String tableNameWithType = configs.get(MinionConstants.TABLE_NAME_KEY);
Expand Down Expand Up @@ -121,12 +120,12 @@ protected SegmentConversionResult convert(PinotTaskConfig pinotTaskConfig, File
// Column exists in segment.
if (dataTypeInSegment != dataTypeInSchema) {
// Check if we need to update the data-type. DataType change is dependent on segmentGeneration code converting
// the object to the destination datatype. If the existing data is the column is not compatible with the
// the object to the destination datatype. If the existing data in the column is not compatible with the
// destination data-type, the refresh task will fail.
refreshColumnSet.add(column);
}

// TODO: Maybe we can support singleValue to multi-value conversions are supproted and vice-versa.
// TODO: Maybe we can support singleValue to multi-value conversions and vice-versa.
} else {
refreshColumnSet.add(column);
}
Expand Down