Accept any negative cardinality as unknown in BloomIndexType#18232
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Apr 17, 2026
Merged
Accept any negative cardinality as unknown in BloomIndexType#18232Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang merged 1 commit intoapache:masterfrom
Conversation
Update BloomIndexType to use the relaxed check (`cardinality < 0`) instead of comparing against `Constants.UNKNOWN_CARDINALITY` exactly, so bloom index creation is robust regardless of the sentinel value stored in segment metadata. Also add a TODO to consider changing `UNKNOWN_CARDINALITY` from `Integer.MIN_VALUE` to `-1` after the 1.6.0 release for better readability in stored metadata. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Jackie-Jiang
force-pushed
the
bloom_index_more_robust
branch
from
2223893 to
5e37938
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18232 +/- ##
============================================
- Coverage 63.36% 63.33% -0.03%
Complexity 1627 1627
============================================
Files 3243 3243
Lines 197038 197038
Branches 30466 30466
============================================
- Hits 124845 124802 -43
- Misses 62195 62238 +43
Partials 9998 9998
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
noob-se7en
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
BloomIndexTypeto use the relaxed check (cardinality < 0) instead of comparing againstConstants.UNKNOWN_CARDINALITYexactly, so bloom index creation is robust regardless of the sentinel value stored in segment metadata.Also adds a TODO to consider changing
UNKNOWN_CARDINALITYfromInteger.MIN_VALUEto-1after the 1.6.0 release for better readability in stored metadata.