minor(cleanup): fix 'occurence'/'seperate' typos in comments and javadocs#18302
Merged
Conversation
noob-se7en
approved these changes
Apr 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18302 +/- ##
============================================
+ Coverage 63.59% 63.61% +0.01%
Complexity 1659 1659
============================================
Files 3247 3247
Lines 197495 197495
Branches 30569 30569
============================================
+ Hits 125606 125644 +38
+ Misses 61840 61803 -37
+ Partials 10049 10048 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18226. This is a targeted, behavior-neutral sweep of the low-risk typos called out in the issue scope ("Fix obvious typos and grammar issues in code comments and Javadocs. Keep the sweep low-risk and behavior-neutral.").
Scope of this PR
occurence->occurrencein javadoc and line comments only. Left all parameter names (int occurence,@param occurence) untouched because those are part of the scalar function's public surface and renaming them would be a user-visible change.seperate->separatein config-file comments only. Left the test method namestestStartSeperately/testStartSeperatelyWithStreamingUntaruntouched so build filters and historical test-report links aren't invalidated.Files changed
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java-- Javadoc for fourstrpos-style overloads ("Return the Nth occurrence of a substring...").pinot-common/src/main/java/org/apache/pinot/common/function/scalar/regexp/RegexpReplaceConstFunctions.java-- Javadoc "all occurrences. Match is performed in case-sensitive mode."pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java-- two// Test occurrencecomments.pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java-- two// Test occurrencecomments.pinot-core/src/test/resources/conf/pinot-broker.properties--# Comma separated list of servers....pinot-server/src/test/resources/conf/pinot-broker.properties-- same comment.Deliberately out of scope
supprotedtypo originally quoted fromRefreshSegmentTaskExecutor.javais no longer in that file on master (already fixed at some point since the issue was filed), so nothing to do there.successfullstill has around 30 hits but many are embedded in log keys, downstream-parsed status strings, and compressor enum names where a rename isn't comment-only; skipping for safety.occurencein public SQL-reachable function signatures) are deliberately untouched to stay behavior-neutral.Verification
cleanup,code-style,testing(two test files touched for comment text only).