Move caching Null Bitmap to NullValueVectorReaderImpl's contructor#18399
Merged
Conversation
rhodo
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18399 +/- ##
============================================
+ Coverage 63.44% 63.51% +0.06%
- Complexity 1698 1709 +11
============================================
Files 3253 3250 -3
Lines 199009 198945 -64
Branches 30823 30825 +2
============================================
+ Hits 126263 126357 +94
+ Misses 62668 62512 -156
+ Partials 10078 10076 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
noob-se7en
reviewed
May 2, 2026
Contributor
noob-se7en
left a comment
noob-se7en
left a comment
There was a problem hiding this comment.
0 critical / 0 major / 1 medium test cleanup — see inline.
Jackie-Jiang
approved these changes
May 4, 2026
Jackie-Jiang
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cache null bitmap as index reader creation time rather than query time.