Skip to content

Make RangeIndexBasedFilterOperator canEvaluate public#18448

Merged
Jackie-Jiang merged 1 commit into
apache:masterfrom
xiangfu0:codex/range-index-can-evaluate-public
May 9, 2026
Merged

Make RangeIndexBasedFilterOperator canEvaluate public#18448
Jackie-Jiang merged 1 commit into
apache:masterfrom
xiangfu0:codex/range-index-can-evaluate-public

Conversation

@xiangfu0
Copy link
Copy Markdown
Contributor

@xiangfu0 xiangfu0 commented May 8, 2026

Summary

  • Make RangeIndexBasedFilterOperator.canEvaluate a public static helper so callers outside the package can reuse the existing range-index eligibility logic.

User manual / examples

  • Not applicable. This is a Java API visibility change only; it does not alter table config, query syntax, or runtime behavior.

Validation

  • ./mvnw -pl pinot-core -am -DskipTests compile

@xiangfu0 xiangfu0 force-pushed the codex/range-index-can-evaluate-public branch from 6d23bf3 to 3dc8852 Compare May 8, 2026 23:38
@xiangfu0 xiangfu0 marked this pull request as ready for review May 8, 2026 23:38
@Jackie-Jiang Jackie-Jiang added the minor Small or trivial change label May 9, 2026
@Jackie-Jiang Jackie-Jiang merged commit 142003c into apache:master May 9, 2026
11 checks passed
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.66%. Comparing base (b8653ef) to head (3dc8852).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #18448   +/-   ##
=========================================
  Coverage     63.66%   63.66%           
  Complexity     1735     1735           
=========================================
  Files          3254     3254           
  Lines        199446   199446           
  Branches      30977    30977           
=========================================
+ Hits         126968   126973    +5     
+ Misses        62342    62340    -2     
+ Partials      10136    10133    -3     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-21 63.66% <ø> (+<0.01%) ⬆️
temurin 63.66% <ø> (+<0.01%) ⬆️
unittests 63.65% <ø> (+<0.01%) ⬆️
unittests1 55.72% <ø> (+<0.01%) ⬆️
unittests2 34.95% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiangfu0 xiangfu0 deleted the codex/range-index-can-evaluate-public branch May 9, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Small or trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants