Fix NPE in HelixHelper.getOfflineInstanceFromExternalView when ExternalView is null#18455
Merged
yashmayya merged 1 commit intoMay 11, 2026
Merged
Conversation
…ceExternalView is null The sibling method getOnlineInstanceFromExternalView already guards against a null ExternalView; apply the same null check to getOfflineInstanceFromExternalView so both methods are consistent and callers that pass a null view (e.g. when the resource is not yet created) get an empty set instead of a NullPointerException.
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18455 +/- ##
============================================
+ Coverage 63.40% 63.65% +0.24%
- Complexity 1679 1684 +5
============================================
Files 3253 3256 +3
Lines 198767 199549 +782
Branches 30791 30987 +196
============================================
+ Hits 126034 127013 +979
+ Misses 62659 62402 -257
- Partials 10074 10134 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Out of curiosity, how do you use this method? Seems it is not used in the code base |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getOfflineInstanceFromExternalView()iterates directly overresourceExternalView.getPartitionSet()without a null guard. Passing anullExternalView(e.g. when the resource has not yet been created in Helix) throws aNullPointerException.The sibling method
getOnlineInstanceFromExternalView()already has the correct null guard:This PR applies the same pattern to
getOfflineInstanceFromExternalView()so both methods are consistent and callers get an empty set instead of an NPE.Test plan
nullreturns an empty set (matchesgetOnlineInstanceFromExternalViewbehaviour)