Skip to content

Fix null-safety and contract violations in HadoopPinotFS #18457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yashmayya merged 2 commits into from
May 11, 2026
Merged

Fix null-safety and contract violations in HadoopPinotFS #18457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1340e2b
Fix null-safety and contract violations in HadoopPinotFS
Akanksha-kedia May 11, 2026
c62dcb4
Fix visitFileStatus to throw IOException instead of silently returnin…
Akanksha-kedia May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions ...ile-system/pinot-hdfs/src/main/java/org/apache/pinot/plugin/filesystem/HadoopPinotFS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@ private void visitFileStatus(Path path, boolean recursive, Consumer<FileStatus>
throws IOException {
// _hadoopFS.listFiles(path, false) will not return directories as files, thus use listStatus(path) here.
FileStatus[] files = _hadoopFS.listStatus(path);
if (files == null) {
Comment thread
Akanksha-kedia marked this conversation as resolved.
throw new IOException("FileSystem.listStatus() returned null for path: " + path);
}
for (FileStatus file : files) {
visitor.accept(file);
if (file.isDirectory() && recursive) {
Expand Down Expand Up @@ -234,32 +237,25 @@ public void copyFromLocalDir(File srcFile, URI dstUri)
}

@Override
public boolean isDirectory(URI uri) {
try {
return _hadoopFS.getFileStatus(new Path(uri)).isDirectory();
} catch (IOException e) {
LOGGER.error("Could not get file status for {}", uri, e);
throw new RuntimeException(e);
}
public boolean isDirectory(URI uri)
throws IOException {
return _hadoopFS.getFileStatus(new Path(uri)).isDirectory();
}

@Override
public long lastModified(URI uri) {
try {
return _hadoopFS.getFileStatus(new Path(uri)).getModificationTime();
} catch (IOException e) {
LOGGER.error("Could not get file status for {}", uri, e);
throw new RuntimeException(e);
}
public long lastModified(URI uri)
throws IOException {
return _hadoopFS.getFileStatus(new Path(uri)).getModificationTime();
}

@Override
public boolean touch(URI uri)
throws IOException {
Path path = new Path(uri);
if (!exists(uri)) {
FSDataOutputStream fos = _hadoopFS.create(path);
fos.close();
try (FSDataOutputStream fos = _hadoopFS.create(path)) {
// create an empty file; stream closed by try-with-resources
}
} else {
_hadoopFS.setTimes(path, System.currentTimeMillis(), -1);
}
Expand Down Expand Up @@ -307,7 +303,9 @@ private org.apache.hadoop.conf.Configuration getConf(String hadoopConfPath) {
@Override
public void close()
throws IOException {
_hadoopFS.close();
if (_hadoopFS != null) {
_hadoopFS.close();
}
super.close();
}
}
Loading