Skip to content

[fix] Fix NPE in StreamOp.fetchExistingTotalDocs when exceptions array is present #18491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akanksha-kedia wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

[fix] Fix NPE in StreamOp.fetchExistingTotalDocs when exceptions array is present #18491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/StreamOp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,12 @@ private long fetchExistingTotalDocs(String tableName)
String errorMsg =
String.format("Failed when running query: '%s'; got exceptions:\n%s\n", query, response.toPrettyString());
JsonNode exceptions = response.get(EXCEPTIONS);
JsonNode errorCode = exceptions.get(ERROR_CODE);
if (QueryErrorCode.BROKER_INSTANCE_MISSING.getId() == errorCode.asInt()) {
// exceptions is a JSON array; iterate to find any transient error code before failing
JsonNode firstException = exceptions.get(0);
JsonNode errorCode = firstException != null ? firstException.get(ERROR_CODE) : null;
int code = errorCode != null ? errorCode.asInt() : -1;
if (QueryErrorCode.BROKER_INSTANCE_MISSING.getId() == code
|| QueryErrorCode.BROKER_SEGMENT_UNAVAILABLE.getId() == code) {
LOGGER.warn("{}.Trying again", errorMsg);
return 0;
}
Expand Down
Loading