Preserve queryableDocIds tracking when preloading upsert segment with no valid docs#18527
Merged
xiangfu0 merged 3 commits intoMay 19, 2026
Merged
Conversation
deepthi912
added
upsert
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18527 +/- ##
=========================================
Coverage 63.75% 63.75%
Complexity 1932 1932
=========================================
Files 3292 3292
Lines 201470 201471 +1
Branches 31316 31317 +1
=========================================
+ Hits 128442 128447 +5
- Misses 62735 62736 +1
+ Partials 10293 10288 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiangfu0
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
When an immutable upsert segment is preloaded via BasePartitionUpsertMetadataManager.doPreloadSegment() and its validdocids.bitmap.snapshot file deserializes to an empty bitmap, the fast-path early-return calls:
segment.enableUpsert(this, new ThreadSafeMutableRoaringBitmap(), null);For tables that track queryable docs (i.e. deleteRecordColumn is configured), passing null for queryableDocIds sets _queryableDocIds = null on ImmutableSegmentImpl. This violates the invariant held everywhere else in upsert: when queryable tracking is enabled, the bitmap must be non-null (empty is fine, null is not).