Improve Kinesis consumer throttling handling#18531
Merged
Merged
Conversation
KKcorps
force-pushed
the
kinesis-rate-limit-fix
branch
2 times, most recently
from
e75565b to
f9406c9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18531 +/- ##
============================================
+ Coverage 63.72% 64.27% +0.54%
+ Complexity 1932 1136 -796
============================================
Files 3292 3311 +19
Lines 201471 203916 +2445
Branches 31317 31730 +413
============================================
+ Hits 128392 131066 +2674
+ Misses 62796 62339 -457
- Partials 10283 10511 +228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiangfu0
reviewed
May 20, 2026
Contributor
xiangfu0
left a comment
xiangfu0
left a comment
There was a problem hiding this comment.
Found one high-signal issue; see inline comment.
xiangfu0
approved these changes
May 21, 2026
Kinesis GetRecords and GetShardIterator throttling happens before Pinot's post-fetch consumption limiters can help, so the consumer now coordinates per-JVM request rate, supports fractional RPS configuration, and backs off boundedly on AWS throttle responses before returning a no-progress batch.
KKcorps
force-pushed
the
kinesis-rate-limit-fix
branch
from
f9406c9 to
c34ce4e
Compare
Contributor
|
Docs PR: pinot-contrib/pinot-docs#820 |
xiangfu0
added a commit
to pinot-contrib/pinot-docs
that referenced
this pull request
May 22, 2026
## Summary Documents the Kinesis throttling behavior change from [apache/pinot#18531](apache/pinot#18531). ## Changes - update the Kinesis ingestion guide for fractional `requests_per_second_limit` values - document the shared read-rate limiter and bounded retry behavior - correct the Kinesis connector reference defaults to match the shipped source ## Validation - cross-checked against the local `apache/pinot` Kinesis connector source - ran `git diff --check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
AWS throttling occurs before Pinot's post-fetch realtime consumption limiters run. When Kinesis rejects GetRecords, Pinot currently logs the throttle and returns an empty batch immediately, which can keep the consumer in a no-progress polling loop. Moving the control into the Kinesis consumer gives Pinot a way to coordinate local read pressure and back off before surfacing a no-progress batch.
Configuration
Reviewer Notes