add broker config options for sql log redaction#18604
Open
jadami10 wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
i accidentally broke #18430. @xiangfu0 @Jackie-Jiang anymore comments on this? I want to avoid more conflicts since this touches so many lines |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18604 +/- ##
============================================
- Coverage 56.82% 56.77% -0.05%
Complexity 7 7
============================================
Files 2567 2567
Lines 149066 149143 +77
Branches 24103 24111 +8
============================================
- Hits 84700 84677 -23
- Misses 57178 57274 +96
- Partials 7188 7192 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new feature to support query redaction. By default, query logs are not redacted.
With
literal_values, we use the the query fingerprint to only log the redacted query with no literal values. This is useful if folks still want the structure of the query without potentially leaking PII.This also fixes a bug where query fingerprinting was modifying the AST in place and breaking queries. This closes #18426.this was fixed yesterday in a better way.
The final option is full redaction. This is good if you want no SQL ending up in your logging system.
I tested all options internally on a QA cluster. We plan to stick with
fullredaction going forward.