Make dateTimeConvert scalar function robust to typed time-value input#18814
Merged
Jackie-Jiang merged 1 commit intoJun 19, 2026
Merged
Conversation
The dateTimeConvert scalar function previously declared its time-value parameter as String, forcing every input to be stringified before parsing. This widens the parameter to Object and dispatches on the input format the same way DateTimeConversionTransformFunction does: EPOCH / TIMESTAMP input is read as a LONG, SIMPLE_DATE_FORMAT input is read as a STRING. The input value is coerced to the target type using the same PinotDataType conversion as FunctionInvoker.convertTypes, so numeric columns, numeric strings, and the date-related logical types produced by the RecordExtractor contract (java.sql.Timestamp, java.time.LocalDate, java.time.LocalTime) are all accepted.
Jackie-Jiang
added
ingestion
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18814 +/- ##
============================================
+ Coverage 64.80% 64.82% +0.01%
Complexity 1319 1319
============================================
Files 3388 3388
Lines 210228 210231 +3
Branches 32948 32949 +1
============================================
+ Hits 136229 136273 +44
+ Misses 63028 62997 -31
+ Partials 10971 10961 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xiangfu0
approved these changes
Jun 19, 2026
cypherean
pushed a commit
to cypherean/pinot
that referenced
this pull request
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
dateTimeConvertscalar function previously declared its time-value parameter asString, forcing every input to be stringified before parsing. This widens the parameter toObjectand dispatches on the input format the same way [DateTimeConversionTransformFunction] does:EPOCH/TIMESTAMPinput is read as aLONG.SIMPLE_DATE_FORMATinput is read as aSTRING.The input value is coerced to the target type using the same
PinotDataTypeconversion as [FunctionInvoker#convertTypes], so numeric columns, numeric strings, and the date-related logical types produced by theRecordExtractorcontract (java.sql.Timestamp,java.time.LocalDate,java.time.LocalTime) are all accepted forEPOCH/TIMESTAMPinput rather than being forced through a stringify-then-parse round trip.This also drops a dead
_bucketingTimeZonefield that was only ever assigned, never read.Added
testDateTimeConvertRecordExtractorDateTypescovering theTIMESTAMP/DATE/TIMElogical types from theRecordExtractorcontract.