Make the server query meter table level#18882
Conversation
|
@Jackie-Jiang is it better to add a new meter with a different name dedicated for table level, or keep it like my current change? |
J-HowHuang
added
metrics
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18882 +/- ##
=========================================
Coverage 64.79% 64.80%
Complexity 1322 1322
=========================================
Files 3393 3393
Lines 211235 211334 +99
Branches 33206 33234 +28
=========================================
+ Hits 136878 136951 +73
- Misses 63303 63323 +20
- Partials 11054 11060 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xiangfu0
left a comment
xiangfu0
left a comment
There was a problem hiding this comment.
Found a high-signal issue; see inline comment.
| */ | ||
| public enum ServerMeter implements AbstractMetrics.Meter { | ||
| QUERIES("queries", true), | ||
| QUERIES_ON_TABLE("queries", false), |
There was a problem hiding this comment.
(optional) I prefer TABLE_QUERIES, but completely optional
There was a problem hiding this comment.
I think QUERIES_ON_TABLE makes sense as in "how many queries on table" versus "how many table queries"
4 participants
Description
The query meter didn't carry table information since #9001. Adding it so we can track table level QPS