Expose the query executor init config via QueryExecutor#getQueryExecutorConfig#18886
Merged
Merged
Conversation
…torConfig Add a getQueryExecutorConfig() accessor to the QueryExecutor interface (default returns an empty PinotConfiguration) and implement it in ServerQueryExecutorV1Impl by retaining the configuration passed to init(). This lets a caller that supplies a per-execution PlanMaker override (the execute(..., PlanMaker) overload) initialize that PlanMaker with the same settings the executor's own plan maker uses, so the override honors limits such as max.execution.threads and the group-by trim sizes instead of falling back to defaults. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
xiangfu0
approved these changes
Jun 30, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18886 +/- ##
============================================
+ Coverage 64.77% 64.78% +0.01%
Complexity 1318 1318
============================================
Files 3393 3393
Lines 211559 211562 +3
Branches 33283 33283
============================================
+ Hits 137029 137071 +42
+ Misses 63458 63415 -43
- Partials 11072 11076 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
raghavyadav01
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
QueryExecutor#getQueryExecutorConfig()so callers can read thePinotConfigurationthe executor was initialized with (thepinot.server.query.executorsubset).PinotConfiguration(back-compatible for any implementation that does not track its init config).ServerQueryExecutorV1Implretains the config passed toinit(...)and returns it.Motivation
A caller that supplies a per-execution
PlanMakeroverride (theexecute(..., PlanMaker)overload) currently has no way to obtain the executor's configuration, so it cannot initialize thatPlanMakerwith the same settings the executor's own plan maker uses. As a result the override silently falls back toInstancePlanMakerImplV2defaults and ignores server limits such asmax.execution.threadsand the group-by trim sizes. This accessor lets such an override be initialized from the executor's real config.Compatibility
Purely additive: a new default interface method plus a stored field and getter. No existing signatures change and no behavior changes for current callers.
🤖 Generated with Claude Code