Remove unused sortable flag from FieldSpec.DataType#18903
Merged
Jackie-Jiang merged 1 commit intoJul 1, 2026
Conversation
xiangfu0
approved these changes
Jul 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18903 +/- ##
=========================================
Coverage 64.80% 64.80%
Complexity 1347 1347
=========================================
Files 3393 3393
Lines 211666 211661 -5
Branches 33305 33305
=========================================
+ Hits 137164 137171 +7
+ Misses 63431 63418 -13
- Partials 11071 11072 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
sortableflag fromFieldSpec.DataType:_sortablefield and thecanBeASortedColumn()method, which has no callers anywhere in the codebase (dead code).sortablefield fromDataTypeProperties, so it no longer appears in theGET /schemas/fieldSpecmetadata response. No consumer (including the controller UI) reads this field.@JsonIgnoreProperties(ignoreUnknown = true)onDataTypePropertiesso deserializers remain tolerant of payloads from older versions that still includesortable.