Add EarlyTerminationException to prevent logging too many invalid error messages#5174
Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom Mar 24, 2020
Merged
Conversation
…or messages When a query times out or is already satisfied, we will cancal the operator execution for early termination. In such case, we should not log error messages as the interruptions are intentional. In case of timeout, it will still be logged in the combine operators once, but not for each individual operators.
jackjlli
reviewed
Mar 23, 2020
Member
jackjlli
left a comment
jackjlli
left a comment
There was a problem hiding this comment.
In case of timeout, it will still be logged in the combine operators once, but not for each individual operators.
Can you point out the message logged in combine operators? I don't see it in this PR though.
| } | ||
| } | ||
| blockingQueue.offer(mergedBlock); | ||
| } catch (EarlyTerminationException e) { |
Member
There was a problem hiding this comment.
Could you add some unit tests/ integration tests for this?
Contributor
Author
|
@jackjlli It is very hard to test the logger behavior. I added some comments in CombineSlowOperatorsTest for the expected behavior. |
jackjlli
approved these changes
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a query times out or is already satisfied, we will cancal the operator execution for early termination.
In such case, we should not log error messages as the interruptions are intentional.
In case of timeout, it will still be logged in the combine operators once, but not for each individual operators.