Skip to content

fix generator.sh after pinot version bump#5237

Merged
xiangfu0 merged 2 commits intomasterfrom
generator-sh-pinot-0.4.0
Apr 14, 2020
Merged

fix generator.sh after pinot version bump#5237
xiangfu0 merged 2 commits intomasterfrom
generator-sh-pinot-0.4.0

Conversation

@apucher
Copy link
Contributor

@apucher apucher commented Apr 10, 2020

No description provided.

@apucher apucher requested review from kishoreg, npawar and xiangfu0 April 10, 2020 07:06
@apucher apucher requested a review from xiangfu0 April 13, 2020 23:53
Copy link
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-io
Copy link

codecov-io commented Apr 14, 2020

Codecov Report

Merging #5237 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5237      +/-   ##
============================================
- Coverage     66.31%   66.07%   -0.24%     
  Complexity       12       12              
============================================
  Files          1057     1057              
  Lines         54176    54176              
  Branches       8069     8069              
============================================
- Hits          35925    35798     -127     
- Misses        15625    15751     +126     
- Partials       2626     2627       +1     
Impacted Files Coverage Δ Complexity Δ
...er/validation/BrokerResourceValidationManager.java 25.00% <0.00%> (-56.25%) 0.00% <0.00%> (ø%)
...ller/validation/OfflineSegmentIntervalChecker.java 32.05% <0.00%> (-51.29%) 0.00% <0.00%> (ø%)
...apache/pinot/common/metrics/ValidationMetrics.java 47.45% <0.00%> (-28.82%) 0.00% <0.00%> (ø%)
...ot/core/io/reader/impl/ConstantMVForwardIndex.java 28.57% <0.00%> (-28.58%) 0.00% <0.00%> (ø%)
...a/manager/realtime/RealtimeSegmentDataManager.java 50.00% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
.../impl/dictionary/LongOffHeapMutableDictionary.java 53.76% <0.00%> (-24.74%) 0.00% <0.00%> (ø%)
...mpl/dictionary/DoubleOffHeapMutableDictionary.java 49.46% <0.00%> (-12.91%) 0.00% <0.00%> (ø%)
.../impl/dictionary/FloatOnHeapMutableDictionary.java 64.63% <0.00%> (-12.20%) 0.00% <0.00%> (ø%)
...impl/dictionary/FloatOffHeapMutableDictionary.java 61.29% <0.00%> (-11.83%) 0.00% <0.00%> (ø%)
...r/dociditerators/RangelessBitmapDocIdIterator.java 72.22% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 235b474...366612d. Read the comment docs.

@xiangfu0 xiangfu0 merged commit 0880f10 into master Apr 14, 2020
@xiangfu0 xiangfu0 deleted the generator-sh-pinot-0.4.0 branch April 14, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants