Excluding eclipse project meta files (#5623)#5624
Open
Sreemanth wants to merge 3 commits intoapache:masterfrom
Open
Excluding eclipse project meta files (#5623)#5624Sreemanth wants to merge 3 commits intoapache:masterfrom
Sreemanth wants to merge 3 commits intoapache:masterfrom
Conversation
Jackie-Jiang
reviewed
Jul 8, 2020
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
I'm not using Eclipse, but do you need to add these files to the gitignore?
Member
|
@Sreemanth can you address the comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Excluding eclipse project meta files while building binaries maven command
Upgrade Notes