Conversation
loading HL realtime segments.
mcvsubbu
reviewed
Sep 22, 2016
| IndexLoadingConfigMetadata configMetadata = new IndexLoadingConfigMetadata(configuration); | ||
| IndexSegment segment = Loaders.IndexSegment.load(new File(resourceDir, segmentMetatdaZk.getSegmentName()), mode, configMetadata); | ||
| IndexSegment segment = Loaders.IndexSegment.load(new File(resourceDir, segmentMetatdaZk.getSegmentName()), mode, | ||
| realtimeTableDataManager.getIndexLoadingConfigMetadata()); |
Contributor
There was a problem hiding this comment.
This has to be tested thoroughly. Not sure if there something else in the indexloading config that we wanted to avoid. I don't think there is, but I am not sure.
Contributor
There was a problem hiding this comment.
IndexLoadingConfig has only 3 things -
- list of inverted indexes to create/load
- segment version
- star tree version
(3) should not matter because there is no star tree (2) is what we want to add. For (1), we need to ensure that is correctly set. From reading of code, it should be.
mcvsubbu
approved these changes
Sep 22, 2016
Contributor
mcvsubbu
left a comment
mcvsubbu
left a comment
There was a problem hiding this comment.
I recommend deploying in EI first and not as a hot patch.
Contributor
|
As an aside, the LLRealtimeSegmentDataManager seems to use a different code path for building segments. We can look into this later. |
Current coverage is 63.98% (diff: 100%)
|
timothy-e
added a commit
to timothy-e/pinot
that referenced
this pull request
Apr 8, 2026
cc stripe-private-oss-forks/pinot-reviewers r? When multistage adaptive server selector stats collection is enabled (pinot.broker.adaptive.server.selector.enable.stats.collection=true), the broker tracks per-server routing stats (in-flight request count, latency EMA, hybrid score) in memory but has no way to observe them externally without hitting the broker's debug API. This makes it difficult to monitor the health and behavior of adaptive routing in production. This PR adds `setValueOfGaugeWithTag(gauge, tag, value)` to `AbstractMetrics`, which composes the metric name as `gaugeName.tag` without going through `getTableName()`. This ensures the server instance ID is always present in the metric name regardless of the `enableTableLevelMetrics` broker config. Also adds `BrokerMetrics.getTagForServer(serverInstanceId)` returning "server.<instanceId>", following the same pattern as `getTagForPreferredPool`. The resulting Pinot metric names are of the form: `pinot.broker.adaptiveServerLatencyEma.server.Server_pinotdb1_8098` **PluginConfig.yaml + statsd reporter** Following https://trailhead.corp.stripe.com/docs/stream-analytics-internal/pinot/pinot-observability/pinot-metrics-guide, adds a labeled metric pattern that extracts the server instance ID as a server tag, so the metrics arrive in Veneur/Prometheus as: - Name: pinot_broker_adaptive_server_latency_ema - Tags: server=Server_pinotdb1_8098 (plus standard host tags) [STREAMANALYTICS-4390](https://jira.corp.stripe.com/browse/STREAMANALYTICS-4390) Unit tests to verify that we: * don't export when adaptive routing stats are disabled * don't export when adaptive routing stats metric export is disabled * transform the metric name properly. [Deployed to QA rad-canary](https://amp.qa.corp.stripe.com/deploy/qa-deploy1.pdx.deploy.stripe.net%2Fdeploy_qBdrdOKZQ7iya8JplJbdaw), and [metrics appeared in grafana](https://g-8916660cfe.grafana-workspace.us-west-2.amazonaws.com/explore?schemaVersion=1&panes=%7B%223yy%22:%7B%22datasource%22:%22zb219lV4k%22,%22queries%22:%5B%7B%22refId%22:%22B%22,%22expr%22:%22%7B__name__%3D~%5C%22pinot_broker_adaptive_server_%28latency_ema%7Cnum_in_flight_requests%7Chybrid_score%29%5C%22,%5Cn%20%20pinot_cluster%3D%5C%22rad-canary%5C%22,host%3D%5C%22qa-pinotdbbroker--06621e6804f2c92db.northwest.stripe.io%5C%22%7D%22,%22range%22:true,%22instant%22:true,%22datasource%22:%7B%22type%22:%22prometheus%22,%22uid%22:%22zb219lV4k%22%7D,%22editorMode%22:%22code%22,%22legendFormat%22:%22__auto%22%7D%5D,%22range%22:%7B%22from%22:%221775151966533%22,%22to%22:%221775152978766%22%7D%7D%7D&orgId=1) as `{__name__=~"pinot_broker_adaptive_server_(latency_ema|num_in_flight_requests|hybrid_score)", pinot_cluster="rad-canary"}`. Stripe-Original-Repo: stripe-private-oss-forks/pinot Stripe-Monotonic-Timestamp: v2/2026-04-07T17:09:47Z/0 Stripe-Original-PR: https://git.corp.stripe.com/stripe-private-oss-forks/pinot/pull/581 (cherry picked from commit 8d84c8980f2122e5290b15d3889282eee8f5286f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.