Data and query generator bytes-column support#6235
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6235 +/- ##
===========================================
- Coverage 66.44% 46.37% -20.08%
===========================================
Files 1075 1240 +165
Lines 54773 58940 +4167
Branches 8168 8737 +569
===========================================
- Hits 36396 27331 -9065
- Misses 15700 29367 +13667
+ Partials 2677 2242 -435
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Comment on lines
+188
to
+190
| // for raw bytes | ||
| String hexRaw = StringUtils.stripStart(Hex.encodeHexString(((ByteBuffer) avroValue).array()), "0"); | ||
| String hexAligned = (hexRaw.length() & 0x1) == 0 ? hexRaw : "0" + hexRaw; |
Contributor
There was a problem hiding this comment.
Why not directly using Hex.encodeHexString(((ByteBuffer) avroValue).array())?
Contributor
There was a problem hiding this comment.
Also, does Avro always have ByteBuffer backed by an array?
|
|
||
| private final Map<String, DataType> dataTypesMap; | ||
| private final Map<String, FieldType> fieldTypesMap; | ||
| private final Map<String, Boolean> singleValueFlagsMap; |
Contributor
There was a problem hiding this comment.
Are we capable of generating MV values?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for raw BYTES columns to data and query generators to expand future testing capabilities. Furthermore, support multi-value columns in the data generator and increase control over dialect and query logging in the query runner.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
No
Does this PR fix a zero-downtime upgrade introduced earlier?
No
Does this PR otherwise need attention when creating release notes? Things to consider:
No