Explicitly enable lead controller resource#6725
Merged
Conversation
jackjlli
added
the
release-notes
Jackie-Jiang
approved these changes
Mar 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #6725 +/- ##
===========================================
- Coverage 73.83% 43.61% -30.22%
===========================================
Files 1396 1402 +6
Lines 67765 67915 +150
Branches 9807 9821 +14
===========================================
- Hits 50035 29622 -20413
- Misses 14485 35816 +21331
+ Partials 3245 2477 -768
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR explicitly enables lead controller resource.
The purpose of this feature is to logically separate per-table functionality in all clusters.
After enabling lead controller resource, the controller host listed under
CONTROLLER/LEADERZNode only denotes the helix lead controller in the cluster.The lead Pinot controller for each of the tables can be found by the following APIs:
Get the leaders for all the tables in the cluster
GET /leader/tables
Given a table name, return the partition id and lead controller instance id
GET /leader/tables/{tableName}
The
RESOURCE_ENABLEDconfig is to be removed whenever we release 0.8 or later version of Pinot.Details can be found in doc: https://cwiki.apache.org/confluence/display/PINOT/Controller+Separation+between+Helix+and+Pinot
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
This PR explicitly enabled lead controller resource. The controller host listed in
CONTROLLER/LEADERZNode only denotes the helix lead controller in the cluster. The actual logic (like controller periodic tasks, realtime segment completion) of Pinot lead controller is distributed to each of the Pinot only controllers.After enabling this feature, Helix controller and Pinot controller don't have to be run in the same hardware.
Documentation
See https://cwiki.apache.org/confluence/display/PINOT/Controller+Separation+between+Helix+and+Pinot