Do not shade jar for pinot native plug-in components#7245
Merged
snleee merged 1 commit intoapache:masterfrom Aug 3, 2021
Merged
Do not shade jar for pinot native plug-in components#7245snleee merged 1 commit intoapache:masterfrom
snleee merged 1 commit intoapache:masterfrom
Conversation
We create the shaded jars for plug-in modules by default; however, this results in a side effect of large binary release data size. This pr don't create shaded jars for pinot native plug-in components. This reduces the binary release from `848MB` to `566MB`.
Codecov Report
@@ Coverage Diff @@
## master #7245 +/- ##
============================================
- Coverage 73.63% 73.53% -0.10%
Complexity 92 92
============================================
Files 1508 1508
Lines 73970 73970
Branches 10686 10686
============================================
- Hits 54465 54396 -69
- Misses 15936 16012 +76
+ Partials 3569 3562 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snleee
pushed a commit
that referenced
this pull request
Aug 3, 2021
We create the shaded jars for plug-in modules by default; however, this results in a side effect of large binary release data size. This pr don't create shaded jars for pinot native plug-in components. This reduces the binary release from `848MB` to `566MB`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We create the shaded jars for plug-in modules by default; however,
this results in a side effect of large binary release data size.
This pr don't create shaded jars for pinot native plug-in
components. This reduces the binary release from
848MBto566MB.