Fix status return from compat checker#7279
Merged
mcvsubbu merged 1 commit intoapache:masterfrom Aug 11, 2021
Merged
Conversation
checkoutAndBuild.sh was returning a wrong status after failed builds. Fixed it to return the right status.
jackjlli
approved these changes
Aug 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #7279 +/- ##
============================================
+ Coverage 68.95% 68.99% +0.04%
+ Complexity 3185 3183 -2
============================================
Files 1111 1111
Lines 52346 52346
Branches 7812 7812
============================================
+ Hits 36097 36118 +21
+ Misses 13672 13655 -17
+ Partials 2577 2573 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkoutAndBuild.sh was returning a wrong status after failed builds.
Fixed it to return the right status.
Description
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation