Skip to content

Fix status return from compat checker#7279

Merged
mcvsubbu merged 1 commit intoapache:masterfrom
mcvsubbu:fix-compat
Aug 11, 2021
Merged

Fix status return from compat checker#7279
mcvsubbu merged 1 commit intoapache:masterfrom
mcvsubbu:fix-compat

Conversation

@mcvsubbu
Copy link
Contributor

checkoutAndBuild.sh was returning a wrong status after failed builds.
Fixed it to return the right status.

Description

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

checkoutAndBuild.sh was returning a wrong status after failed builds.
Fixed it to return the right status.
@codecov-commenter
Copy link

Codecov Report

Merging #7279 (44e7e17) into master (6ef7f94) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7279      +/-   ##
============================================
+ Coverage     68.95%   68.99%   +0.04%     
+ Complexity     3185     3183       -2     
============================================
  Files          1111     1111              
  Lines         52346    52346              
  Branches       7812     7812              
============================================
+ Hits          36097    36118      +21     
+ Misses        13672    13655      -17     
+ Partials       2577     2573       -4     
Flag Coverage Δ
unittests1 68.99% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../startree/v2/builder/OffHeapSingleTreeBuilder.java 87.42% <0.00%> (-4.20%) ⬇️
...e/impl/forward/FixedByteMVMutableForwardIndex.java 90.90% <0.00%> (-3.04%) ⬇️
...e/pinot/segment/local/io/util/PinotDataBitSet.java 96.03% <0.00%> (-1.59%) ⬇️
...main/java/org/apache/pinot/spi/data/FieldSpec.java 80.85% <0.00%> (-0.54%) ⬇️
...cal/startree/v2/builder/BaseSingleTreeBuilder.java 89.23% <0.00%> (+0.89%) ⬆️
.../java/org/apache/pinot/spi/data/TimeFieldSpec.java 90.90% <0.00%> (+2.27%) ⬆️
...ot/segment/local/startree/OffHeapStarTreeNode.java 77.77% <0.00%> (+5.55%) ⬆️
...pache/pinot/core/util/SortedRangeIntersection.java 88.23% <0.00%> (+7.35%) ⬆️
...nt/local/startree/v2/store/StarTreeDataSource.java 53.33% <0.00%> (+13.33%) ⬆️
...core/startree/operator/StarTreeFilterOperator.java 83.68% <0.00%> (+15.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef7f94...44e7e17. Read the comment docs.

@mcvsubbu mcvsubbu merged commit 6fb51d2 into apache:master Aug 11, 2021
@mcvsubbu mcvsubbu deleted the fix-compat branch August 11, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants