Add cleanup method for HadoopSegmentCreationJob #7371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7371 +/- ##
============================================
+ Coverage 70.39% 71.65% +1.26%
- Complexity 3299 3308 +9
============================================
Files 1508 1515 +7
Lines 74754 74976 +222
Branches 10846 10908 +62
============================================
+ Hits 52621 53727 +1106
+ Misses 18508 17622 -886
- Partials 3625 3627 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
siddharthteotia
approved these changes
Aug 30, 2021
jackjlli
force-pushed
the
add-cleanup-method-for-HadoopSegmentCreationJob
branch
from
a5ce208 to
0efff97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This method adds cleanup method for HadoopSegmentCreationJob.
The method didn't get added to the base class as not all the subclasses that extend the base class create a Job object (e.g. SegmentTarPushJob doesn’t initialize a job object).
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation