Update some usage of BatchConfig#7459
Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom Sep 21, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7459 +/- ##
=============================================
- Coverage 71.91% 30.33% -41.59%
=============================================
Files 1519 1510 -9
Lines 75335 75002 -333
Branches 10980 10943 -37
=============================================
- Hits 54177 22750 -31427
- Misses 17508 50238 +32730
+ Partials 3650 2014 -1636
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
approved these changes
Sep 21, 2021
walterddr
pushed a commit
to walterddr/pinot
that referenced
this pull request
Sep 23, 2021
Merged
apucher
pushed a commit
that referenced
this pull request
Sep 23, 2021
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looking at the usage of StreamConfig and BatchConfig. it seems like they should be used as
Therefore, changing some of the API usages of BatchConfig.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
NO
Does this PR fix a zero-downtime upgrade introduced earlier?
NO
Does this PR otherwise need attention when creating release notes? Things to consider:
Documentation
N/A