Skip to content

add SingleSpaceSeparator rule and fix recent violations#7467

Merged
kishoreg merged 1 commit intoapache:masterfrom
richardstartin:single-space-separator
Sep 22, 2021
Merged

add SingleSpaceSeparator rule and fix recent violations#7467
kishoreg merged 1 commit intoapache:masterfrom
richardstartin:single-space-separator

Conversation

@richardstartin
Copy link
Member

Description

I recently committed changes with double white spaces by mistake. This removes them and adds a checkstyle rule to prevent it from happening again.

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@kishoreg kishoreg merged commit 5b15f08 into apache:master Sep 22, 2021
@richardstartin richardstartin deleted the single-space-separator branch October 8, 2021 21:40
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants