Make the static utility methods in SegmentAssignmentUtils public.
#7561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SegmentAssignmentUtils` contains some segment assignment static utility functions that can be used standalone. Making them public.
xiangfu0
approved these changes
Oct 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #7561 +/- ##
============================================
+ Coverage 72.54% 72.64% +0.09%
+ Complexity 3416 3415 -1
============================================
Files 1522 1522
Lines 75905 75905
Branches 11093 11093
============================================
+ Hits 55069 55138 +69
+ Misses 17144 17077 -67
+ Partials 3692 3690 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
atris
pushed a commit
to atris/incubator-pinot
that referenced
this pull request
Oct 19, 2021
The `SegmentAssignmentUtils` contains some segment assignment static utility functions that can be used standalone. Making them public.
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
The `SegmentAssignmentUtils` contains some segment assignment static utility functions that can be used standalone. Making them public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
SegmentAssignmentUtilscontains some segment assignment static utilitymethods that can be used standalone. Making them public.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation