Closed
Conversation
walterddr
commented
Oct 15, 2021
| return DEFAULT_READER.forType(valueTypeRef).readValue(jsonString); | ||
| } | ||
|
|
||
| public static <T> List<T> stringToList(String jsonString, Class<T> valueType) |
Contributor
Author
There was a problem hiding this comment.
dont know where to add test the best, it doesn't seem like the others are tested individually either.
Member
There was a problem hiding this comment.
I really think these should be tested though. If all new code is tested, coverage can't get worse.
Contributor
Author
There was a problem hiding this comment.
sounds good. I take this as ok to create a separate test file entirely to cover the non-tested JsonUtils functions. will do it soon
Contributor
Author
|
actually closing this. I think we should directly use/test the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there's no JsonUtils.toList for
StringorInputStreamorbyte[]input type, only forFile. Adding the other 3