Ignore shardIterator type when sequence number is available#7592
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7592 +/- ##
============================================
- Coverage 72.54% 64.16% -8.39%
- Complexity 3416 3804 +388
============================================
Files 1522 1543 +21
Lines 75905 78636 +2731
Branches 11093 11671 +578
============================================
- Hits 55069 50457 -4612
- Misses 17144 24579 +7435
+ Partials 3692 3600 -92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes issue #7555.
The shard iterator type should be set to AFTER_SEQUENCE_NUMBER if a valid sequence number is available to start.
Otherwise, LATEST or TRIM_HORIZON should be taken based on provided shard iterator type.