Skip to content

Ignore shardIterator type when sequence number is available#7592

Merged
KKcorps merged 1 commit into
apache:masterfrom
KKcorps:kinesis_start_offset_patch
Oct 20, 2021
Merged

Ignore shardIterator type when sequence number is available#7592
KKcorps merged 1 commit into
apache:masterfrom
KKcorps:kinesis_start_offset_patch

Conversation

@KKcorps
Copy link
Copy Markdown
Contributor

@KKcorps KKcorps commented Oct 18, 2021

The PR fixes issue #7555.

The shard iterator type should be set to AFTER_SEQUENCE_NUMBER if a valid sequence number is available to start.
Otherwise, LATEST or TRIM_HORIZON should be taken based on provided shard iterator type.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 18, 2021

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.16%. Comparing base (493ed2c) to head (1a9b030).
⚠️ Report is 6901 commits behind head on master.

Files with missing lines Patch % Lines
...e/pinot/plugin/stream/kinesis/KinesisConsumer.java 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (493ed2c) and HEAD (1a9b030). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (493ed2c) HEAD (1a9b030)
unittests2 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7592      +/-   ##
============================================
- Coverage     72.54%   64.16%   -8.39%     
- Complexity     3416     3804     +388     
============================================
  Files          1522     1543      +21     
  Lines         75905    78636    +2731     
  Branches      11093    11671     +578     
============================================
- Hits          55069    50457    -4612     
- Misses        17144    24579    +7435     
+ Partials       3692     3600      -92     
Flag Coverage Δ
integration1 29.40% <0.00%> (-0.92%) ⬇️
integration2 27.77% <0.00%> (-1.14%) ⬇️
unittests1 68.54% <ø> (-1.31%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@npawar npawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTm

@KKcorps KKcorps merged commit d595346 into apache:master Oct 20, 2021
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants