Skip to content

Refactor QueryOptions into QueryOptionsUtils to avoid redundant parsing#7601

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:query_context_options
Oct 20, 2021
Merged

Refactor QueryOptions into QueryOptionsUtils to avoid redundant parsing#7601
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:query_context_options

Conversation

@Jackie-Jiang
Copy link
Contributor

Avoid creating QueryOptions class which parses all the options but only access one of them.
Query options can never be null during the query parsing, so no need to perform extra null checks.

@Jackie-Jiang Jackie-Jiang force-pushed the query_context_options branch from 30ce7c9 to 0999d21 Compare October 19, 2021 23:52
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #7601 (0999d21) into master (aed6ada) will decrease coverage by 0.08%.
The diff coverage is 69.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7601      +/-   ##
============================================
- Coverage     71.61%   71.53%   -0.09%     
  Complexity     3884     3884              
============================================
  Files          1552     1559       +7     
  Lines         79012    79016       +4     
  Branches      11705    11702       -3     
============================================
- Hits          56585    56523      -62     
- Misses        18618    18684      +66     
  Partials       3809     3809              
Flag Coverage Δ
integration1 29.20% <56.47%> (-0.22%) ⬇️
integration2 27.91% <58.82%> (+0.04%) ⬆️
unittests1 68.59% <75.00%> (+<0.01%) ⬆️
unittests2 14.74% <5.88%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pinot/core/plan/maker/InstancePlanMakerImplV2.java 72.61% <33.33%> (-0.95%) ⬇️
...roker/requesthandler/BaseBrokerRequestHandler.java 70.86% <51.51%> (-0.16%) ⬇️
...core/query/executor/ServerQueryExecutorV1Impl.java 82.48% <62.50%> (+0.16%) ⬆️
...ava/org/apache/pinot/core/plan/FilterPlanNode.java 82.60% <75.00%> (-0.73%) ⬇️
...t/core/query/reduce/SelectionDataTableReducer.java 76.92% <83.33%> (+1.45%) ⬆️
...he/pinot/core/common/datatable/DataTableUtils.java 91.45% <100.00%> (ø)
...perator/combine/GroupByOrderByCombineOperator.java 80.72% <100.00%> (-0.46%) ⬇️
...t/core/plan/AggregationGroupByOrderByPlanNode.java 50.00% <100.00%> (-5.27%) ⬇️
...va/org/apache/pinot/core/plan/CombinePlanNode.java 88.33% <100.00%> (-0.20%) ⬇️
...core/query/reduce/AggregationDataTableReducer.java 82.08% <100.00%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed6ada...0999d21. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit cb065e4 into apache:master Oct 20, 2021
@Jackie-Jiang Jackie-Jiang deleted the query_context_options branch October 20, 2021 18:42
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants