Refactor QueryOptions into QueryOptionsUtils to avoid redundant parsing#7601
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Oct 20, 2021
Merged
Conversation
70e2faf to
30ce7c9
Compare
xiangfu0
approved these changes
Oct 19, 2021
30ce7c9 to
0999d21
Compare
Codecov Report
@@ Coverage Diff @@
## master #7601 +/- ##
============================================
- Coverage 71.61% 71.53% -0.09%
Complexity 3884 3884
============================================
Files 1552 1559 +7
Lines 79012 79016 +4
Branches 11705 11702 -3
============================================
- Hits 56585 56523 -62
- Misses 18618 18684 +66
Partials 3809 3809
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid creating QueryOptions class which parses all the options but only access one of them.
Query options can never be
nullduring the query parsing, so no need to perform extranullchecks.