avoid repeating column stats work when values are repeated#7619
Merged
Jackie-Jiang merged 3 commits intoapache:masterfrom Oct 25, 2021
Merged
avoid repeating column stats work when values are repeated#7619Jackie-Jiang merged 3 commits intoapache:masterfrom
Jackie-Jiang merged 3 commits intoapache:masterfrom
Conversation
richardstartin
force-pushed
the
avoid-repetitive-work
branch
from
5aba742 to
9704eac
Compare
Codecov Report
@@ Coverage Diff @@
## master #7619 +/- ##
============================================
- Coverage 71.61% 63.02% -8.59%
+ Complexity 3938 3876 -62
============================================
Files 1562 1553 -9
Lines 79370 79046 -324
Branches 11748 11720 -28
============================================
- Hits 56843 49822 -7021
- Misses 18692 25613 +6921
+ Partials 3835 3611 -224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mayankshriv
approved these changes
Oct 25, 2021
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
By checking whether a value has been added to the _values set before, we can avoid doing things like UTF-8 encoding, evaluating partitioning functions and so on more than once. Also avoid expensive boxing, reference equality of boxed values, comparator evaluation for primitive types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By checking whether a value has been added to the
_valuesset before, we can avoid doing things like UTF-8 encoding, evaluating partitioning functions and so on more than once.Also avoid expensive boxing, reference equality of boxed values, comparator evaluation for primitive types.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation