Skip to content

Skip schema check for lookup function#7670

Merged
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:skip_schema_check_for_functions
Nov 1, 2021
Merged

Skip schema check for lookup function#7670
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:skip_schema_check_for_functions

Conversation

@xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Nov 1, 2021

Description

Skip schema check for lookup function

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@xiangfu0 xiangfu0 requested a review from Jackie-Jiang November 1, 2021 06:38
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #7670 (85ce988) into master (b2add14) will increase coverage by 0.96%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7670      +/-   ##
============================================
+ Coverage     70.60%   71.57%   +0.96%     
  Complexity     4030     4030              
============================================
  Files          1578     1578              
  Lines         80248    80249       +1     
  Branches      11914    11914              
============================================
+ Hits          56662    57441     +779     
+ Misses        19721    18939     -782     
- Partials       3865     3869       +4     
Flag Coverage Δ
integration1 29.15% <0.00%> (+0.10%) ⬆️
integration2 27.68% <0.00%> (?)
unittests1 68.59% <ø> (-0.01%) ⬇️
unittests2 14.55% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...roker/requesthandler/BaseBrokerRequestHandler.java 71.39% <0.00%> (+2.13%) ⬆️
...mmon/request/context/predicate/NotEqPredicate.java 66.66% <0.00%> (-6.67%) ⬇️
.../pinot/core/query/scheduler/PriorityScheduler.java 80.82% <0.00%> (-2.74%) ⬇️
.../org/apache/pinot/core/startree/StarTreeUtils.java 69.89% <0.00%> (-2.16%) ⬇️
...core/startree/operator/StarTreeFilterOperator.java 86.52% <0.00%> (-2.13%) ⬇️
...ava/org/apache/pinot/core/plan/FilterPlanNode.java 82.69% <0.00%> (-1.93%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 52.84% <0.00%> (-1.56%) ⬇️
.../aggregation/function/ModeAggregationFunction.java 86.75% <0.00%> (-1.36%) ⬇️
...lix/core/minion/PinotHelixTaskResourceManager.java 44.18% <0.00%> (-0.78%) ⬇️
...va/org/apache/pinot/controller/ControllerConf.java 57.31% <0.00%> (ø)
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2add14...85ce988. Read the comment docs.

@xiangfu0 xiangfu0 merged commit 1b4241d into apache:master Nov 1, 2021
@xiangfu0 xiangfu0 deleted the skip_schema_check_for_functions branch November 1, 2021 18:57
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants