Skip to content

Comments

Take acquire/release call to MinMaxValueBasedSelectionOrderByCombineOperator#7681

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
npawar:acquire_release_minmaxoperator
Nov 3, 2021
Merged

Take acquire/release call to MinMaxValueBasedSelectionOrderByCombineOperator#7681
Jackie-Jiang merged 1 commit intoapache:masterfrom
npawar:acquire_release_minmaxoperator

Conversation

@npawar
Copy link
Contributor

@npawar npawar commented Nov 2, 2021

No description provided.

@npawar npawar requested a review from Jackie-Jiang November 2, 2021 22:36
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #7681 (cded2e2) into master (2107b2c) will increase coverage by 37.80%.
The diff coverage is 33.33%.

❗ Current head cded2e2 differs from pull request most recent head e2cf203. Consider uploading reports for the commit e2cf203 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master    #7681       +/-   ##
=============================================
+ Coverage     30.79%   68.60%   +37.80%     
- Complexity        0     3952     +3952     
=============================================
  Files          1570     1184      -386     
  Lines         80024    57854    -22170     
  Branches      11904     8891     -3013     
=============================================
+ Hits          24644    39688    +15044     
+ Misses        53274    15352    -37922     
- Partials       2106     2814      +708     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 68.60% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nMaxValueBasedSelectionOrderByCombineOperator.java 61.06% <33.33%> (-14.33%) ⬇️
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/core/data/manager/realtime/TimerService.java 0.00% <0.00%> (-100.00%) ⬇️
...not/common/exception/HttpErrorStatusException.java 0.00% <0.00%> (-100.00%) ⬇️
...t/core/startree/plan/StarTreeDocIdSetPlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...ot/common/restlet/resources/TableMetadataInfo.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1353 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2107b2c...e2cf203. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit 5bf15cf into apache:master Nov 3, 2021
richardstartin added a commit to richardstartin/pinot that referenced this pull request Nov 3, 2021
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants