Skip to content

try fixing common test#7699

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
walterddr:test_fix_common_test
Nov 4, 2021
Merged

try fixing common test#7699
Jackie-Jiang merged 1 commit intoapache:masterfrom
walterddr:test_fix_common_test

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Nov 3, 2021

at least I can reproduce locally with these lines in and fix locally with these removed

@codecov-commenter
Copy link

Codecov Report

Merging #7699 (4c65278) into master (14c377d) will increase coverage by 34.24%.
The diff coverage is 91.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #7699       +/-   ##
=============================================
+ Coverage     30.86%   65.10%   +34.24%     
- Complexity        0     4033     +4033     
=============================================
  Files          1571     1535       -36     
  Lines         80040    78526     -1514     
  Branches      11906    11740      -166     
=============================================
+ Hits          24703    51128    +26425     
+ Misses        53225    23749    -29476     
- Partials       2112     3649     +1537     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 68.61% <91.66%> (?)
unittests2 14.55% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ment/spi/loader/SegmentDirectoryLoaderContext.java 75.00% <75.00%> (ø)
...indexsegment/immutable/ImmutableSegmentLoader.java 91.25% <100.00%> (+91.25%) ⬆️
...ment/local/loader/LocalSegmentDirectoryLoader.java 100.00% <100.00%> (+100.00%) ⬆️
...ndex/converter/SegmentV1V2ToV3FormatConverter.java 77.61% <100.00%> (+77.61%) ⬆️
...local/segment/index/loader/IndexLoadingConfig.java 65.40% <100.00%> (+65.40%) ⬆️
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1278 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8961b0...4c65278. Read the comment docs.

@walterddr walterddr marked this pull request as ready for review November 4, 2021 00:13
@Jackie-Jiang Jackie-Jiang merged commit e80198d into apache:master Nov 4, 2021
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Test fails when sharing the JVM among multiple tests accessing `HttpServer`
@walterddr walterddr deleted the test_fix_common_test branch December 6, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants