Skip to content

[Cleanup] Remove the old deprecated SegmentConverter#7725

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:remove_merge_rollup_converter
Nov 9, 2021
Merged

[Cleanup] Remove the old deprecated SegmentConverter#7725
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:remove_merge_rollup_converter

Conversation

@Jackie-Jiang
Copy link
Contributor

Description

All the functionality of SegmentConverter is replaced by SegmentProcessorFramework.

Release Notes

MergeSegments is no longer available in pinot-admin, use SegmentProcessorFramework instead

@Jackie-Jiang Jackie-Jiang added release-notes Referenced by PRs that need attention when compiling the next release notes backward-incompat Referenced by PRs that introduce or fix backward compat issues labels Nov 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #7725 (c1c9a9a) into master (94a17f3) will increase coverage by 13.33%.
The diff coverage is n/a.

❗ Current head c1c9a9a differs from pull request most recent head e18e833. Consider uploading reports for the commit e18e833 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master    #7725       +/-   ##
=============================================
+ Coverage     14.51%   27.85%   +13.33%     
=============================================
  Files          1536     1566       +30     
  Lines         78679    79941     +1262     
  Branches      11764    11900      +136     
=============================================
+ Hits          11422    22264    +10842     
+ Misses        66418    55662    -10756     
- Partials        839     2015     +1176     
Flag Coverage Δ
integration2 27.85% <ø> (?)
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pinot/controller/recommender/io/ConfigManager.java 0.00% <0.00%> (-100.00%) ⬇️
...troller/recommender/io/metadata/FieldMetadata.java 0.00% <0.00%> (-100.00%) ⬇️
...roller/recommender/rules/impl/BloomFilterRule.java 0.00% <0.00%> (-100.00%) ⬇️
...oller/api/resources/PinotControllerAppConfigs.java 0.00% <0.00%> (-100.00%) ⬇️
...ler/recommender/data/generator/BytesGenerator.java 0.00% <0.00%> (-100.00%) ⬇️
...er/recommender/io/metadata/SchemaWithMetaData.java 0.00% <0.00%> (-100.00%) ⬇️
...r/recommender/rules/impl/AggregateMetricsRule.java 0.00% <0.00%> (-100.00%) ⬇️
.../recommender/exceptions/InvalidInputException.java 0.00% <0.00%> (-100.00%) ⬇️
.../recommender/rules/io/configs/PartitionConfig.java 0.00% <0.00%> (-100.00%) ⬇️
.../recommender/rules/utils/PredicateParseResult.java 0.00% <0.00%> (-100.00%) ⬇️
... and 769 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a17f3...e18e833. Read the comment docs.

@Jackie-Jiang Jackie-Jiang force-pushed the remove_merge_rollup_converter branch from f70af79 to e18e833 Compare November 9, 2021 00:29
@Jackie-Jiang Jackie-Jiang merged commit 8d83973 into apache:master Nov 9, 2021
@Jackie-Jiang Jackie-Jiang deleted the remove_merge_rollup_converter branch November 9, 2021 22:52
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
All the functionality of SegmentConverter is replaced by SegmentProcessorFramework.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backward-incompat Referenced by PRs that introduce or fix backward compat issues release-notes Referenced by PRs that need attention when compiling the next release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants