get parameters in logging statement right way round#7963
Merged
mayankshriv merged 1 commit intoapache:masterfrom Jan 6, 2022
Merged
get parameters in logging statement right way round#7963mayankshriv merged 1 commit intoapache:masterfrom
mayankshriv merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7963 +/- ##
============================================
- Coverage 71.34% 70.31% -1.03%
- Complexity 4191 4192 +1
============================================
Files 1595 1595
Lines 82568 82568
Branches 12320 12320
============================================
- Hits 58906 58060 -846
- Misses 19678 20528 +850
+ Partials 3984 3980 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mayankshriv
approved these changes
Jan 5, 2022
walterddr
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This debug logging identified cases where empty batches would be produced, which no longer choke the consume loop, but unfortunately the parameters are the wrong way round.