Skip to content

Remove PQL response parser in quickstart#8081

Merged
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:remove_pql_response_parser_in_quickstart
Jan 28, 2022
Merged

Remove PQL response parser in quickstart#8081
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:remove_pql_response_parser_in_quickstart

Conversation

@xiangfu0
Copy link
Contributor

Description

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@xiangfu0 xiangfu0 requested a review from Jackie-Jiang January 27, 2022 23:20
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #8081 (69a4737) into master (e7ea235) will increase coverage by 33.24%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #8081       +/-   ##
=============================================
+ Coverage     37.93%   71.17%   +33.24%     
- Complexity       81     4262     +4181     
=============================================
  Files          1606     1607        +1     
  Lines         83405    83409        +4     
  Branches      12455    12458        +3     
=============================================
+ Hits          31638    59370    +27732     
+ Misses        49311    19998    -29313     
- Partials       2456     4041     +1585     
Flag Coverage Δ
integration1 28.92% <ø> (+0.01%) ⬆️
integration2 27.73% <ø> (+0.13%) ⬆️
unittests1 67.88% <ø> (?)
unittests2 14.29% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/manager/realtime/RealtimeSegmentDataManager.java 50.00% <0.00%> (-25.00%) ⬇️
...not/broker/broker/helix/ClusterChangeMediator.java 77.65% <0.00%> (-2.13%) ⬇️
...core/query/executor/ServerQueryExecutorV1Impl.java 83.02% <0.00%> (-1.38%) ⬇️
...lix/core/realtime/PinotRealtimeSegmentManager.java 82.72% <0.00%> (-1.05%) ⬇️
...server/starter/helix/HelixInstanceDataManager.java 79.44% <0.00%> (-0.56%) ⬇️
...roker/requesthandler/BaseBrokerRequestHandler.java 71.08% <0.00%> (-0.20%) ⬇️
.../java/org/apache/pinot/spi/filesystem/PinotFS.java 0.00% <0.00%> (ø)
...pache/pinot/core/query/utils/idset/EmptyIdSet.java 25.00% <0.00%> (ø)
...pinot/core/query/request/context/TimerContext.java 91.66% <0.00%> (ø)
...troller/helix/core/retention/RetentionManager.java 83.33% <0.00%> (ø)
... and 897 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ea235...69a4737. Read the comment docs.

@xiangfu0 xiangfu0 merged commit 0fe7ef8 into apache:master Jan 28, 2022
@xiangfu0 xiangfu0 deleted the remove_pql_response_parser_in_quickstart branch January 28, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants