Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8185 +/- ##
=============================================
+ Coverage 30.67% 71.34% +40.66%
- Complexity 0 4303 +4303
=============================================
Files 1612 1623 +11
Lines 83962 84314 +352
Branches 12602 12640 +38
=============================================
+ Hits 25754 60150 +34396
+ Misses 55919 20036 -35883
- Partials 2289 4128 +1839
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is flaky because the table config and schema update is not atomic. It is okay for the update to be eventual consistency (update multiple maps in order). Enhance the test to handle that.
Example failure run: https://github.com/apache/pinot/runs/5132494061?check_suite_focus=true