Skip to content

Fix the flaky TableCacheTest#8185

Merged
xiangfu0 merged 1 commit intoapache:masterfrom
Jackie-Jiang:fix_table_cache_test
Feb 10, 2022
Merged

Fix the flaky TableCacheTest#8185
xiangfu0 merged 1 commit intoapache:masterfrom
Jackie-Jiang:fix_table_cache_test

Conversation

@Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Feb 10, 2022

The test is flaky because the table config and schema update is not atomic. It is okay for the update to be eventual consistency (update multiple maps in order). Enhance the test to handle that.

Example failure run: https://github.com/apache/pinot/runs/5132494061?check_suite_focus=true

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #8185 (ba53375) into master (6844cb3) will increase coverage by 40.66%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #8185       +/-   ##
=============================================
+ Coverage     30.67%   71.34%   +40.66%     
- Complexity        0     4303     +4303     
=============================================
  Files          1612     1623       +11     
  Lines         83962    84314      +352     
  Branches      12602    12640       +38     
=============================================
+ Hits          25754    60150    +34396     
+ Misses        55919    20036    -35883     
- Partials       2289     4128     +1839     
Flag Coverage Δ
integration1 28.86% <ø> (-0.06%) ⬇️
integration2 27.55% <ø> (+<0.01%) ⬆️
unittests1 67.88% <ø> (?)
unittests2 14.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...data/manager/realtime/DefaultSegmentCommitter.java 0.00% <0.00%> (-80.00%) ⬇️
...er/api/resources/LLCSegmentCompletionHandlers.java 43.56% <0.00%> (-18.82%) ⬇️
...data/manager/realtime/SegmentCommitterFactory.java 88.23% <0.00%> (-11.77%) ⬇️
...altime/ServerSegmentCompletionProtocolHandler.java 51.42% <0.00%> (-6.67%) ⬇️
...core/startree/operator/StarTreeFilterOperator.java 85.31% <0.00%> (-2.10%) ⬇️
...lix/core/minion/PinotHelixTaskResourceManager.java 44.18% <0.00%> (-0.78%) ⬇️
...nMaxValueBasedSelectionOrderByCombineOperator.java 70.45% <0.00%> (-0.76%) ⬇️
...pache/pinot/core/query/utils/idset/EmptyIdSet.java 25.00% <0.00%> (ø)
...ata/manager/realtime/RealtimeTableDataManager.java 68.27% <0.00%> (ø)
...anager/realtime/SegmentBuildTimeLeaseExtender.java 63.23% <0.00%> (ø)
... and 1112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6844cb3...ba53375. Read the comment docs.

@xiangfu0 xiangfu0 merged commit 8d867ed into apache:master Feb 10, 2022
@Jackie-Jiang Jackie-Jiang deleted the fix_table_cache_test branch February 10, 2022 17:36
@xiangfu0 xiangfu0 linked an issue Feb 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TableCacheTest is flaky

3 participants