Merged
Conversation
69422e9 to
506e9b6
Compare
506e9b6 to
d44bbfc
Compare
snleee
approved these changes
Feb 17, 2022
Contributor
snleee
left a comment
There was a problem hiding this comment.
LGTM. This looks much cleaner.
Codecov Report
@@ Coverage Diff @@
## master #8214 +/- ##
============================================
- Coverage 71.02% 62.64% -8.39%
+ Complexity 4314 4232 -82
============================================
Files 1626 1614 -12
Lines 84929 84634 -295
Branches 12783 12749 -34
============================================
- Hits 60325 53015 -7310
- Misses 20462 27724 +7262
+ Partials 4142 3895 -247
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
approved these changes
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the
DataTypeenum which I noticed could be simplified while investigating another issue.