add more testing for MV var-length columns, detect overflow scenarios#8286
Merged
richardstartin merged 1 commit intoapache:masterfrom Mar 3, 2022
Merged
Conversation
e43a843 to
e32266e
Compare
Jackie-Jiang
approved these changes
Mar 3, 2022
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8286 +/- ##
============================================
- Coverage 70.82% 70.77% -0.05%
- Complexity 4239 4243 +4
============================================
Files 1631 1631
Lines 85461 85463 +2
Branches 12877 12879 +2
============================================
- Hits 60527 60486 -41
- Misses 20749 20804 +55
+ Partials 4185 4173 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a bug report of a buffer overflow creating MV string raw forward index, with the following stack trace:
I have added extensive testing for the impacted components and could not find any buffer overflows, and have narrowed this down to an integer overflow such that the product of
Integer.BYTES + maxRowLengthInBytes + maxLengthPrefixesand a fixednumDocsPerChunkoverflows and is non-negative. Very large MV values is a limitation of the current implementation and I have added precondition checks to detect overflow unambiguously.