Skip to content

Add dateTimeConvert scalar function#8292

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:date_time_convert_scalar
Mar 4, 2022
Merged

Add dateTimeConvert scalar function#8292
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:date_time_convert_scalar

Conversation

@Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Mar 4, 2022

Add the dateTimeConvert scalar function which is equivalent to the DateTimeConversionTransformFunction so that it can be used for ingestion transform and post aggregation

@Jackie-Jiang Jackie-Jiang requested a review from xiangfu0 March 4, 2022 01:27
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #8292 (556a203) into master (46ed731) will decrease coverage by 1.01%.
The diff coverage is 87.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8292      +/-   ##
============================================
- Coverage     70.83%   69.81%   -1.02%     
- Complexity     4245     4247       +2     
============================================
  Files          1631     1631              
  Lines         85462    85487      +25     
  Branches      12877    12879       +2     
============================================
- Hits          60539    59687     -852     
- Misses        20746    21663     +917     
+ Partials       4177     4137      -40     
Flag Coverage Δ
integration1 29.05% <0.00%> (+0.06%) ⬆️
integration2 ?
unittests1 66.98% <87.87%> (+0.02%) ⬆️
unittests2 14.20% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...inot/common/function/scalar/DateTimeFunctions.java 95.91% <87.87%> (-2.72%) ⬇️
...t/core/plan/StreamingInstanceResponsePlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...ore/operator/streaming/StreamingResponseUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...ager/realtime/PeerSchemeSplitSegmentCommitter.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/core/plan/StreamingSelectionPlanNode.java 0.00% <0.00%> (-88.89%) ⬇️
...ator/streaming/StreamingSelectionOnlyOperator.java 0.00% <0.00%> (-87.81%) ⬇️
...re/query/reduce/SelectionOnlyStreamingReducer.java 0.00% <0.00%> (-85.72%) ⬇️
...pache/pinot/common/utils/grpc/GrpcQueryClient.java 0.00% <0.00%> (-80.86%) ⬇️
...ller/api/access/BasicAuthAccessControlFactory.java 0.00% <0.00%> (-80.00%) ⬇️
...roker/requesthandler/GrpcBrokerRequestHandler.java 0.00% <0.00%> (-78.58%) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ed731...556a203. Read the comment docs.

@xiangfu0
Copy link
Contributor

xiangfu0 commented Mar 4, 2022

Please add the PR description

@Jackie-Jiang Jackie-Jiang merged commit 90d1136 into apache:master Mar 4, 2022
@Jackie-Jiang Jackie-Jiang deleted the date_time_convert_scalar branch March 4, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants