In TableCache, invoke callback on config change listener during registration#8302
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Mar 7, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8302 +/- ##
============================================
- Coverage 70.77% 64.05% -6.73%
Complexity 4246 4246
============================================
Files 1631 1586 -45
Lines 85485 83617 -1868
Branches 12878 12679 -199
============================================
- Hits 60502 53559 -6943
- Misses 20815 26196 +5381
+ Partials 4168 3862 -306
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when the config change listener is registered, the callback is not triggered automatically. It relies on the caller to set the current configs into the change listener, which is hard to use because there might be other changes invoking the
onChange()callback at the same time.This PR changes the listener registration method to directly call the
onChange()with the current configs.Also improve the test and fix #8153