Open
Conversation
mneedham
force-pushed
the
transform-config-error-messages
branch
from
f5ea923 to
359cee7
Compare
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
I don't follow why we need this change. The cause should be logged in the stack trace (unless the same exception repeated too many times and the stack trace is truncated in the log)
Contributor
Author
|
The full stack trace doesn't seem to get logged because the status code is 400. See: Also, I think it's a better user experience if you get a message back telling you what you've done wrong rather than a vague message that will result in someone coming to the OSS Slack and asking what it means, to then be told to look at the log file! I should say this exact thing did happen on this thread here: |
richardstartin
approved these changes
Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a transform config that doesn't compile, the error message will only tell you that it's an invalid transform config, it doesn't say what the problem is.
This PR passes through the message from the underlying cause exception.